jvrubel commented on PR #28526:
URL: https://github.com/apache/camel/pull/28526#issuecomment-6576353579
Hello, thanks for the reviews. Here is how your concerns were addressed:
1. SingletonCliService missing executeNohup delegation — Added an explicit
@Override for executeNohup
in SingletonCliService so the proxy forwards to the wrapped service
instead of falling back to the
interface default (which used executeGenericCommand rather than the
process-aware override in
CliLocalProcessService).
2. runDownloadedFromGithubTest lost its original intent — The test was
accidentally made identical to
runDownloadedInDirectoryFromGithubTest (both used
--directory=mountPoint()). Restored the original
behavior: init without --directory so files land in the command working
directory, then assert their
presence via
containerService.listDirectory(containerService.getCommandWorkDir()) and run
with run
*. This also avoids the null-safety issue with File.listFiles() on
non-existent paths.
3. infraListTest still present in InfrastructureITCase — The method was
extracted to
InfrastructureListITCase but not removed from the original class,
causing it to run twice in
container mode. Removed the duplicate.
4. Maven settings file deleted by per-test cleanup —
createMavenSettingsFile() was creating the file
inside workDir, which gets cleaned between tests by find workDir -not
-name '.*' -delete. Changed
Files.createTempFile(workDir, …) to Files.createTempFile(…) so the file
lands in the system temp
directory and survives the cleanup.
5. Dead DEFAULT_ROUTE_FOLDER field — All callers had already been migrated
to
containerService.getCommandWorkDir(). Removed the field and its comment.
6. OpenApiITCase exposed to Windows — The class uses
executeGenericCommand("mkdir -p …") and
executeGenericCommand("mv …"), which are POSIX-only. Added
@DisabledOnOs(WINDOWS) at the class
level.
7. runRoutesFromMultipleFilesUsingWildcardTest exposed to Windows — The
finally block calls
execInContainer("rm -rf …"), which fails on Windows. Added
@DisabledOnOs(WINDOWS) on the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
