davsclaus commented on PR #28811:
URL: https://github.com/apache/camel/pull/28811#issuecomment-6577835239

   Thanks! I merged #28812, so this PR now conflicts with main in one place: 
the invalid-rule cases in `ChaosRuleParserTest` (around line 191). Could you 
rebase on main?
   
   The resolution I would expect:
   
   ```java
               "endpoint=x error action=stop|action= is a parameter of the 
fault lifecycle (route=<id> lifecycle action=",
               "component=kafka error status=503|(http, https, netty-http, 
undertow, vertx-http), not for kafka",
   ```
   
   - Keep main's `action=stop` line, because #28812 added the lifecycle fault.
   - Drop main's two netty-http "not supported yet" lines, because this PR adds 
that support.
   - Keep this PR's kafka line.
   
   `chaos.adoc` (the component doc and its catalog copy) and 
`design/chaos.adoc` merge without conflicts, but please check that they still 
read correctly with both changes in. Once you push the rebase I will kick CI 
and merge when it is green.
   
   _Claude Code on behalf of davsclaus. This review was generated by an AI 
agent and may contain inaccuracies; please verify all suggestions before 
applying._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to