oscerd commented on PR #28959: URL: https://github.com/apache/camel/pull/28959#issuecomment-6588600993
Thanks, Claus. Agreed on the `methodName` enum, done here: `GoogleSheetsConfiguration` now lists the 12 method names of the `data` and `spreadsheets` APIs, so `batchClear`, `batchClearByDataFilter`, `batchGet`, `batchGetByDataFilter`, `batchUpdateByDataFilter` and `getByDataFilter` are in. The new `GoogleSheetsApiMethodsTest.shouldListTheMethodNamesOfTheApisInTheMethodNameOption` compares the enum with the API method names, as in mail and drive, and fails with the old enum. I also ran the catalog validation: before, `google-sheets:data/batchGet` and `spreadsheets/getByDataFilter` reported an invalid `methodName` value; with the regenerated JSON both validate, and `spreadsheets/values` is still rejected. The JSON is copied into the catalog and the endpoint DSL javadoc is regenerated. On the upgrade guide: a short entry under camel-google-sheets now says that the three accessors are removed, that a route with one of them fails when it starts instead of on the first message, and that the values are read and written with the `data` API. _Claude Code on behalf of Andrea Cosentino (oscerd)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
