allthingssecurity commented on PR #29043:
URL: https://github.com/apache/camel/pull/29043#issuecomment-6597525506
Thanks for the review.
1. Done in 792426f1b582. The decoder now reads each byte unsigned (`in.get()
& 0xFF`) in the main loop and in `skipDiscarded`, and keeps the previous byte
unsigned too. So every comparison with the configured `char` start and end
bytes now works above `0x7F`, the existing ones included: the start byte, both
end bytes, and the end-byte-1 adjustment of the limit. The new test
`startAndEndBytesAbove0x7F` uses `0x8b`/`0x9c`/`0x8d` and covers:
- a message at the limit;
- end bytes that arrive in two reads;
- a message over the limit, followed by the next message.
It fails with the previous decoder (the other 13 tests pass). The decoder
and MINA route tests pass 20 times out of 20 (300 tests), and the camel-hl7
tests are 107, 0 failures. I removed this item from the follow-up list in the
description.
2. The `maxFrameLength` row is now one short sentence for both codecs. A
paragraph below the table gives the per-codec details (the exception, the Netty
end-byte count, what happens to the connection). The catalog copy is synced.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
