allthingssecurity commented on PR #29045: URL: https://github.com/apache/camel/pull/29045#issuecomment-6597525857
Thanks, you're right about the order. 1. Fixed in 93ac6d3c0a12. `onStartAttemptFailed` now writes `failedStarts` first and `lastStartFailure` last, and the comment says why: the check reads the failure first, so a failure it sees always comes with its count. `doStart` now clears the two in the reverse order, as `doStop` already did. I've also corrected the description. I didn't add a test: the window lies between two volatile writes inside the retry callback, and a test can't stop there without a hook in production code. The existing health check, first-start and stop-while-starting tests pass 20 times out of 20 (360 tests), and the module has 65 tests, 0 failures. 2. Yes, a runtime check (the processor stopped or lost its leases after it started) is worth a follow-up JIRA. We'll file one, and the description now mentions it. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
