oscerd commented on PR #28947: URL: https://github.com/apache/camel/pull/28947#issuecomment-6599553006
Thanks @davsclaus, you are right and I verified it: `MinaConsumer` never reads `disconnectOnNoReply` (it always closes its session when it has no reply to send, overridable only by the `CamelMinaCloseSessionWhenComplete` header), and #28865 removed the producer's use, so from 4.24.0 the option has no effect. Pushed a corrected revision: - upgrade note reworded to your suggested text; - `MinaProducer` comment at the timeout path corrected; - `MinaConfiguration#setDisconnectOnNoReply` javadoc rewritten to "This option has no effect ..." (catalog + DSL regenerated). Left for a separate follow-up, as you suggested: deciding between deprecating `disconnectOnNoReply` and making the consumer honour it, plus the `noReplyLogLevel` label (it is `consumer,advanced` but only the producer reads it). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
