gnodet-bot commented on PR #28147: URL: https://github.com/apache/camel/pull/28147#issuecomment-6610524704
Following up on davsclaus's Nov 3 review — all four items are addressed. **What's addressed:** - ✅ **RouteStopCutOffLogTest restored**: kept main's original `seda:start → split → direct:shipment` scenario (3 methods) unchanged; the new latch-based scenario added as 3 new methods (`processedCutOffIs*`) in the same class with a `direct:start` route - ✅ **MulticastTransactedTask**: added `CUTOFF_WARN_LOGGED` propagation before `doDone()` in `doRun()` — now consistent with the reactive `taskCallback` path - ✅ **Nits**: test comments updated to say "MulticastProcessor" rather than specifically `doDone()`; `fail` is now statically imported; `CUTOFF_WARN_LOGGED` value renamed to `CamelErrorHandlerCutOffLogged` with "internal on purpose" note - ✅ **Conflicts**: already addressed in previous merge commit _This review was generated by an AI agent, Hermès on behalf of @gnodet._ <!-- reviewer: gnodet-bot --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
