davsclaus commented on PR #29056:
URL: https://github.com/apache/camel/pull/29056#issuecomment-6611220665

   `build (17, false)` fails at "Fail if there are uncommitted changes": the 
conflict resolution left files that the build reformats or regenerates.
   
   - `camel-as2-api/.../AS2AsynchronousMDNManager.java`: the 
`java.security.cert.Certificate` and `java.util.Locale` imports are after the 
`javax.net.ssl` ones, and there is an extra blank line before `createSocket`.
   - `camel-as2-component/.../AS2Configuration.java`: the Javadoc of the 
`asyncMdnRequireHttps` setter starts with `/**` at column 0.
   - `camel-as2-component/src/generated/resources/META-INF/.../as2.json` and 
`catalog/camel-catalog/.../components/as2.json`: they were not regenerated (the 
`component` block has the wrong indentation and unescaped `/`, and the 
`asyncMdnRequireHttps` option is missing or out of date).
   
   Running `mvn formatter:format impsort:sort` and `mvn install -DskipTests` in 
`components/camel-as2` and then in `catalog/camel-catalog`, and committing the 
result, should fix it.
   
   Also, the 4.18.x backport (#29055) adds the "the asynchronous MDN allow-list 
matches the host and port" note to the upgrade guide, but this PR does not. On 
`camel-4.22.x` it belongs under `== Upgrading from 4.22.2 to 4.22.3` in 
`camel-4x-upgrade-guide-4_22.adoc`.
   
   The 4.18.x backport (#29055) is still building. It has the same 
conflict-resolved files, so it may fail the same way.
   
   _Claude Code on behalf of davsclaus_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to