Croway commented on PR #28874: URL: https://github.com/apache/camel/pull/28874#issuecomment-6607016188
`!**/*.citrus.*` only covers some of the files camel-jbang treats as Citrus tests. `RunFiles.isCitrusTest` (CAMEL-26495) and the Citrus 5.1.0 default names also include `*.citrus-it.yaml`, `*.citrus-test.yaml` (and `.xml`/`.groovy`) and `*.feature`, and editing those still reloads the routes. Live `camel run --dev --source-dir=proj`, one file edited at a time: | Edited file | base | this PR | |---|---|---| | `test/orders.citrus.it.yaml` | reload | no reload | | `test/orders.citrus-it.yaml` | reload | reload | | `test/orders.feature` | reload | reload | (reload = `Routes reloaded summary (total:1 started:1 changed:0)`) I checked `*,!**/*.citrus.*,!**/*.citrus-*,!**/*.feature` with the real `RunPipeline.sourceDirReloadPattern` and the `RouteWatcherReloadStrategy` file filter. It leaves all of these out, and `orders.camel.yaml` and `test/stub.camel.yaml` still reload. Citrus tests written as Java/XML classes (`OrdersIT.java`) can't be excluded by name, so a sentence in the docs may help. _Claude Code on behalf of Croway_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
