oscerd commented on PR #29093: URL: https://github.com/apache/camel/pull/29093#issuecomment-6628879543
Thanks @davsclaus — both points addressed in 87a85ef. **"fail at route startup".** You are right, that only holds for the component. I corrected the entry rather than adding the check, and split it in two: the `pqc` component validates in `doStart` and fails there; the `pqc` data format has no length check and fails on the first message when the cipher rejects the key. I also narrowed the list for the data format — of the algorithms it accepts, only `SEED` and `SM4` are affected — and added your point that the algorithm can arrive per message through `CamelPQCSymmetricAlgorithm`, so a route with a fine configured value can still fail on an override. On moving the check into `PQCDataFormat.doStart()`: it fits the existing shape there, which already fails fast on the AEAD check with a comment saying per-message overrides are validated at marshal time. I left it out because the valid-length table lives as a private static in `PQCProducer`, and the data format is in another package — doing it properly means lifting that table somewhere shared (`PQCSymmetricAlgorithms` would be the natural home) and changing the producer too, which is more than this PR should carry. Happy to do it as a follow-up if you want it. **Also fixed, unreported:** the setter javadoc on the component data format still read "Default is 128". **On the rebase heads-up:** noted. Both entries sit in the 4.24 guide; whichever of #29093 / #29098 merges second will need the small rebase. --- One thing to flag, since it nearly went wrong. Regenerating the YAML DSL schemas locally produced a **bad** result: `mvn install -pl dsl/camel-yaml-dsl/...` read the stale `camel-core-model` from `~/.m2` and rewrote `symmetricKeyLength` back to `defaultValue: 128` with the pre-PR description — silently reverting this PR's whole point in four generated files. I caught it on the diff, discarded those regenerations and hand-applied only the description change, preserving `256`. Worth knowing if anyone else regenerates these without a full reactor build first. Every `default` in the final diff is `256`; CI's uncommitted-changes check is the backstop. Full `camel-pqc` build green: 327 tests, 0 failures. _Claude Code on behalf of @oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
