davsclaus commented on code in PR #29107:
URL: https://github.com/apache/camel/pull/29107#discussion_r4457569612
##########
components/camel-docker/src/main/java/org/apache/camel/component/docker/DockerConfiguration.java:
##########
@@ -63,7 +63,7 @@ public class DockerConfiguration implements Cloneable {
private boolean followRedirectFilter;
@UriParam(label = "security", defaultValue = "false")
private boolean tlsVerify;
- @UriParam(label = "advanced", defaultValue = "true")
+ @UriParam(label = "advanced", defaultValue = "false")
Review Comment:
Thanks, good catch. Added an upgrade guide entry (new `camel-docker - the
documented default of the socket option is false` section in the 4.24 guide):
the documented default of `socket` is now `false`, its real default; up to 4.22
Camel Spring Boot applied the documented `true`, so a Spring Boot application
that relied on the socket must set `camel.component.docker.socket=true`, or use
a `unix://` host such as `unix:///var/run/docker.sock`, which this PR supports.
Commit 1a56e8d33896.
_Claude Code on behalf of Claus Ibsen (davsclaus)_
##########
components/camel-docker/src/main/docs/docker-component.adoc:
##########
@@ -35,6 +35,28 @@ include::partial$component-endpoint-headers.adoc[]
== Usage
+=== Connecting to the Docker daemon
+
+By default, the component connects over TCP to `host` and `port`
(`tcp://localhost:2375`). Docker does not open this
+TCP port by default; it has to be enabled in the configuration of the daemon.
+
+To connect to the local unix socket of the daemon instead, set `socket=true`.
In socket mode `host` is the path of the
+socket and `port` is not used. The default host `localhost` means
`/var/run/docker.sock`:
+
+[source,java]
+----
+from("timer:info?repeatCount=1")
+ .to("docker:info?socket=true")
+ .log("${body}");
+----
+
+For a socket in another place, set its path as the host, for example
+`docker:info?socket=true&host=/run/user/1000/docker.sock`.
+
+The host can also be a full Docker host URL with a `tcp://`, `unix://` or
`npipe://` scheme, in the same form as the
Review Comment:
Right, removed `npipe://` from the `host` option description and from the
component doc (regenerated the catalog and DSL files). The doc now says that
named pipes are not supported by the Docker client of the component. The code
still passes an `npipe://` host as is, so it fails early with `Unsupported
protocol scheme` instead of becoming `tcp://npipe:...:2375`. Commit
1a56e8d33896.
_Claude Code on behalf of Claus Ibsen (davsclaus)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
