oscerd opened a new pull request, #1858:
URL: https://github.com/apache/camel-kafka-connector/pull/1858
Fixes #651.
### Change
Until now the marshal/unmarshal options only appeared as table rows in
`basic-configuration.adoc`. The source rows had been copied from the sink ones,
and `CAMEL_SOURCE_MARSHAL_DOC` described `camel.source.marshal` as "unmarshal".
- **New page.** `user-guide/data-formats.adoc`, linked from the nav (outside
the generated connectors block) and from the four table rows. It covers:
- what `camel.{sink,source}.{marshal,unmarshal}` do, and how a data format
differs from a Kafka Connect converter;
- where they run in the route `CamelKafkaConnectMain` builds, relative to
header removal, aggregation and idempotency;
- the Camel 4 data format names, read from the jars' `META-INF/services`.
For example, `jackson` was registered as `json-jackson` in Camel 3.14 and
earlier;
- which connectors already ship a data format, and how to add one to the
plugin directory or through the dataformat archetype;
- `camel.dataformat.<name>.<option>`, and data format beans declared with
`camel.beans`;
- the record value a source-side marshal produces, a security note about
Jackson's `allowUnmarshallType` / `allowJmsType`, and a worked file-sink
example.
- **Table fix.** In `basic-configuration.adoc`, the descriptions of the
source options are corrected.
- **Constant fix.** `CamelSourceConnectorConfig.CAMEL_SOURCE_MARSHAL_DOC`
said "unmarshal" and now says "marshal".
The page describes the record value of a source-side marshal as a `byte[]`,
which is the behaviour after #1852 (#1543). Please merge that PR first.
### Verification
Every behaviour on the page was checked by running the real
`CamelSourceTask` / `CamelSinkTask` on Camel 4.22.0:
- `camel.dataformat.jackson.prettyPrint=true` works, and so does the bean
alternative.
- With both options set, marshal runs before unmarshal.
- `json-jackson`, or a `camel.dataformat.csv.*` property without camel-csv,
makes the task fail to start.
- The file-sink example works end to end.
The pages render without warnings with Asciidoctor.js. `./mvnw -pl core
-Psourcecheck test` passes, and the full reactor build `./mvnw clean verify
-DskipTests` succeeds.
_Claude Code on behalf of Andrea Cosentino_
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
