allthingssecurity commented on PR #29120: URL: https://github.com/apache/camel/pull/29120#issuecomment-6624682806
Thanks @davsclaus, both done in c4cdbe40fdfb: 1. `stopAndDestroyListenerContainer(DetachedListenerContainer)` now destroys the container in a `finally` around `stop()`, and the `onListenerContainerStopped()` call and the shutdown of the private pool are in the outer `finally`, as you suggested, so a failing `Connection.stop()` with `consumerType=Simple` no longer leaks the container or its pool. 2. Yes, I added a short upgrade-guide note: `doStart`/`doStop` no longer call those three protected methods (they are still there), so a subclass that overrides them to change how the container is started or stopped should override `doStart`/`doStop` instead. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
