gnodet commented on PR #28861: URL: https://github.com/apache/camel/pull/28861#issuecomment-6625594708
Hi @davsclaus, both items from your Nov 4 review have been addressed: 1. **PR description** — already reflects the final design: `FileConsumer` override, `File.exists()`, and eager idempotent key removal via `removeExcessiveIdempotentFile()`. 2. **Deterministic test** — `FileConsumerCommittedBeforeClaimTest` was added in commit 6f683e8c. It injects a custom `inProgressRepository` whose `add()` deletes the file (simulating a concurrent commit landing between `contains()` and `add()`), then asserts zero routing, in-progress key released, and eager idempotent key dropped. CI is green. Would you mind re-reviewing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
