oscerd opened a new pull request, #29218:
URL: https://github.com/apache/camel/pull/29218
### What
The upgrade guides for every release line live on `main` and act as the
canonical history across all
releases (see `.oss-ai-helper-rules/project-guidelines.md`). When a change
is backported to a
maintenance branch and adds an upgrade-guide note for that release line, the
same note must also be
present in the corresponding `camel-4x-upgrade-guide-4_XX.adoc` on `main`.
This documentation-only PR carries the `camel-mina` producer note, which the
backports added to their
own release-line guides, into the two matching guides on `main`:
* `docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_22.adoc` -
"Upgrading from 4.22.2 to
4.22.3" section (the change ships in 4.22.3).
* `docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_18.adoc` -
"Upgrading from 4.18.5 to
4.18.6" section (the change ships in 4.18.6).
### Note added to both guides
Each note is the exact text the backport added to that line's guide on the
maintenance branch:
----
=== camel-mina - the producer closes its session when a request times out
A synchronous `mina` producer (`sync=true`) now always closes its session
when a request times out while waiting for a
reply. Because a synchronous producer is pooled and reused for later
exchanges, a session kept open after a timeout
could receive the late reply to the timed-out exchange and hand it to the
next exchange that reused the same producer.
The producer now discards that session, so the next exchange opens a fresh
one.
The default behaviour is unchanged: `disconnectOnNoReply` defaults to
`true`, which already closed the session on a
timeout. Setting `disconnectOnNoReply=false` no longer keeps the producer
session open after a timeout.
----
The note is worded for the older lines: it stops at the producer behaviour.
On `camel-4.22.x` and
`camel-4.18.x` the `mina` consumer does not consult `disconnectOnNoReply`
(it closes the session
whenever it has no reply to send), so there is no consumer behaviour to
describe for the option there,
unlike the 4.24 guide on `main`.
### Related PRs
* #28865 - the change on `main` (4.24.0), which added the note to
`camel-4x-upgrade-guide-4_24.adoc`.
* #28887 - backport to `camel-4.22.x` (4.22.3), which added the note to that
line's guide.
* #28888 - backport to `camel-4.18.x` (4.18.6), which added the note to that
line's guide.
This PR accompanies the two backports and is intended to merge after them;
all three are already
merged. No code changes, documentation only.
_Claude Code on behalf of oscerd_
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
