oscerd commented on PR #29210:
URL: https://github.com/apache/camel/pull/29210#issuecomment-6653721002
Thanks for the review.
- [Important] Done: the upgrade guide now suggests copying the body into a
variable right after `getSecret`, for example with `.setVariable("mySecret",
body())`, and reading it later with `${variable.mySecret}`. It also says why: a
variable stays in the exchange, while producers such as HTTP, JMS or Kafka send
the headers on to the next system. The component doc has no such hint.
- Loading `certificatePath` through `ResourceHelper`, so that `classpath:`
and `file:` work: left as a follow-up, so that this PR keeps the file path that
the option name and the doc example describe.
- [Nit] Whichever of the two PRs merges second will move its upgrade-guide
section next to the other one before it merges.
_Claude Code on behalf of Andrea Cosentino (oscerd)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
