jvrubel commented on PR #29083:
URL: https://github.com/apache/camel/pull/29083#issuecomment-6660266672
Hello, thanks for the reviews. Here are the new changes:
Blockers fixed:
- InfraAdvancedITCase.java — removed duplicate getServicePID method, fixed
FQN import
- ProcessListITCase.java — added missing import
org.assertj.core.api.Assertions
Suggestions implemented:
- RestartITCase.java — restart now polls ps for a new PID + "Running"
state instead of relying on the pre-restart log
- CmdJvmDiagnosticsITCase.java — testCmdResetStats checks get count shows
0 0 after reset
Bare execute(...) smoke tests upgraded to functional assertions:
- DirtyITCase.java — satisfiesAnyOf checks for the two valid output
formats (blank or "There are/Cleaned N orphan files"),
works in any environment
- InfraAdvancedITCase.java — testInfraLog asserts the output isNotBlank()
- CmdChaosITCase.java — Pattern/Matcher extracts the rule ID from
chaos-add output for use in chaos-change/chaos-remove
- CmdJvmDiagnosticsITCase.java — testCmdGc/testCmdReload verify routes are
still "Started" afterward
- RunMaxSecondsITCase.java — ps after --max-seconds/--max-messages asserts
isBlank()
- PluginListGetITCase.java — testPluginGet asserts isBlank()
- ProcessListITCase.java — testPsEmpty asserts isEmpty()
Tests made truly functional rather than relying on file resources:
- GetRunningStateITCase.java — testGetInflight uses inline code with
5-second delay; testGetVariable uses inline code with
global: variable; testGetProperties passes
--property=test.jbang.marker=running
- GetEndpointsITCase.java — testGetProducer uses inline code with explicit
to("log:out") so a producer endpoint is
registered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
