gnodet commented on PR #29149: URL: https://github.com/apache/camel/pull/29149#issuecomment-6660995647
## ✅ Review issues addressed in `f46fc36` All three remaining review issues have been fixed and 43/43 tests pass. ### Issue 1: skipITs map empty in CI (repo-root scan) - Added `_find_repo_root()` helper that walks up from `scan_path` to find the repo root (directory containing `components/` or `.git`) - `run_check()` now builds the skipITs map from the repo root, not just `scan_path`, so component poms under `components/` are found even when scanning `test-infra/` - Also filters out test-infra module poms that declare their own artifactId (not consumers) - Added tests: `FindRepoRootTest` (3 tests), `RunCheckRepoRootTest` (1 integration test) ### Issue 2: Union → Intersection for skipITs across consumers - `_build_component_skip_its_map` now uses **intersection** across all consumer modules: an arch is only exempted when **every** consumer that references a test-infra module skips it - e.g. `camel-test-infra-postgres` keeps s390x because `camel-sql` (no skipITs) intersects with `camel-pgvector` (skipITs.s390x=true) → empty intersection - Added tests: `test_intersection_across_consumers_not_union`, `test_intersection_all_consumers_skip_same_arch`, `test_consumer_without_skip_its_clears_exemption` ### Issue 3: "Not verified" case now visible - `check_architectures()` returns `None` (not `[]`) when the check cannot be performed (network error, auth failure, unknown format) - Added `arch_unverified` field to `VersionCheckResult` (default `False`) - When `None` is returned, upgrade is still proposed but `arch_unverified=true` is set - Human-readable output shows a "⚠️ MULTI-ARCH NOT VERIFIED" section - JSON output includes `arch_unverified` field - Workflow step summary shows a warning line when any images were unverified - Added tests: `ArchUnverifiedTest` (4 tests), updated existing tests for `None` return > _Review fix applied by Hermes on behalf of @gnodet_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
