apupier opened a new pull request, #29226:
URL: https://github.com/apache/camel/pull/29226
UndertowHttpsSpringTest (and UndertowHandlersSpringTest, which uses the same
pattern) obtained its port in the Spring XML through the deprecated
AvailablePortFinder.getNextAvailable(). That method releases the port as soon
as it returns, so the port can be taken by another process before Undertow
binds to it, which fails the context startup with
"java.net.BindException: Address already in use".
The rerun of the failed test then fails with a different error,
"ApplicationContext failure threshold (1) exceeded", because since Spring 6.1 a
context that failed to load is not loaded again by default. As a result the
rerun could never recover from the port collision.
Changes:
- SpringTest.xml / HandlersSpringTest.xml: create the dynaPort bean with
AvailablePortFinder.find() (non deprecated API, port is also registered so it
is not handed out twice in the same JVM) and release it on context shutdown
with destroy-method="close". The endpoint URIs use #{dynaPort.port}.
- UndertowHttpsSpringTest / UndertowHandlersSpringTest: inject the
AvailablePortFinder.Port bean instead of an Integer.
- Add src/test/resources/spring.properties with
spring.test.context.failure.threshold=3 so that a failed ApplicationContext
load can be retried by the surefire reruns (rerunFailingTestsCount=2). The
context is then created again from scratch, including a new port.
Verified that the full camel-undertow test suite passes (293 tests, 0
failures, 0 errors).
Co-authored-by: IBM Bob 2.2.1
# Description
<!--
- Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (Camel 4
uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for
the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other
small items do not require a JIRA issue. In this case your pull request should
address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful
subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX]
Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the
appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally from root folder
and I have committed all auto-generated changes.
<!--
You can run the aforementioned command in your module so that the build
auto-formats your code. This will also be verified as part of the checks and
your PR may be rejected if if there are uncommited changes after running `mvn
clean install -DskipTests`.
You can learn more about the contribution guidelines at
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
# AI-assisted contributions
- [ ] If this PR includes AI-generated code, commits have proper
co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR
description identifies the AI tool used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
