oscerd commented on PR #29058: URL: https://github.com/apache/camel/pull/29058#issuecomment-6637676188
Rebased onto main (signed commits, the branch had no CI run since the upgrade guide conflicted) and pushed `CAMEL-26532: Address review feedback - the concurrent test reaches the re-check under the lock, clearCache takes the lock, and the docs say that a token with an unknown kid is rejected during the cooldown` (c8b3e710bedd): - The upgrade guide entry now sits next to the other camel-keycloak section, and says that a token with an unknown `kid` is rejected while the cooldown suppresses the refresh, and that the refresh runs on the request that needs it, with no background refresh. The "Rate Limiting on Key Rotation" section of keycloak-security.adoc says the same, catalog copy included. - `testConcurrentRequestsWithUnknownKidsTriggerSingleFetch` no longer warms up the cache, so every thread passes the unlocked check and the re-check under the lock is what keeps the fetches down to one; it then checks that a known `kid` resolves from the cache without another fetch. - `clearCache()` takes the lock around its two writes. camel-keycloak unit tests: 167 run, 0 failures. The three open threads are answered. Review re-requested. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
