jiriOndrusek-agent commented on PR #9440: URL: https://github.com/apache/camel-quarkus/pull/9440#issuecomment-6655567583
Thanks for the review. Addressed in 8b5416d04c: **1. `-Dfips.enabled=true` breaks the individual `cxf-soap` modules:** Reproduced, thanks. I scoped the guide: `-Dfips.enabled=true` is now shown only with `-f integration-tests/cxf-soap-grouped`, with a note that the other CXF modules fail to build with it. I kept the exclusions in one place rather than copying them into all 11 group modules: it is a temporary workaround, and #9447 tracks removing it once we are on CXF 4.2.5. **2. The exclusion list can drift:** Added a comment next to the generated dependency section pointing at the fips profile (checked it survives `mvn process-resources -Pformat -N`). The list only has to live until CXF 4.2.5, see #9447. **3. Docs length:** Done: a short `=== FIPS` subsection after the general build tips, with the final `MAVEN_OPTS` line and no jshell walkthrough. **4. Duplicated list:** Yes, the escaping forces it: Maven can't rewrite commas in a property, and the native build args are comma-split. Both lines sit next to each other with a comment, so I left it as is. **5. Convention only in comments:** Agreed it's only a convention. An enforcer rule felt like too much for a FIPS-only setting on JDK 25+. A module that misses it and uses TLS fails on a FIPS host with a handshake error; CI has no FIPS host, so it would only show up on a FIPS run. Happy to add a check if you prefer. _Generated with [Claude Code](https://claude.com/claude-code) on behalf of @JiriOndrusek_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
