squakez commented on code in PR #6922: URL: https://github.com/apache/camel-k/pull/6922#discussion_r4493416814
########## e2e/keda/keda_ibmmq_test.go: ########## @@ -0,0 +1,99 @@ +//go:build integration +// +build integration + +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package keda + +import ( + "context" + "testing" + + . "github.com/onsi/gomega" + . "github.com/onsi/gomega/gstruct" + corev1 "k8s.io/api/core/v1" + + . "github.com/apache/camel-k/v2/e2e/support" + v1 "github.com/apache/camel-k/v2/pkg/apis/camel/v1" +) + +func TestIBMMQKedaAutoDiscoveryAndAutoscale(t *testing.T) { + WithExistingNamedTestNamespace(t, func(ctx context.Context, g *WithT, ns string) { + consumerName := "keda-it-ibmmq-to-log-auto" + producerName := "timer-to-ibmmq" + + // Remove all test resources even if an assertion fails part-way through. + t.Cleanup(func() { Review Comment: The removal of resource is managed by the testing framework. Just make sure to use `WithNewTestNamespace` to generate one random and apply all resources passing the `ns` namespace parameter. ########## e2e/keda/files/ibmmq-ephemeral.yaml: ########## @@ -0,0 +1,122 @@ +# --------------------------------------------------------------------------- +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# --------------------------------------------------------------------------- + +# These credentials are only for the disposable IBM MQ developer broker used +# by the KEDA integration test. The image reads the password keys from +# /run/secrets; they are not passed to the MQ container as environment values. +apiVersion: v1 +kind: Secret +metadata: + name: ibmmq-auth +stringData: + mqAdminUsername: admin + mqAdminPassword: admin-passw0rd + mqAppUsername: app + mqAppPassword: app-passw0rd +--- +apiVersion: apps/v1 +kind: Deployment +metadata: + name: ibmmq +spec: + replicas: 1 + selector: + matchLabels: + app: ibmmq + template: + metadata: + labels: + app: ibmmq + spec: + terminationGracePeriodSeconds: 60 + containers: + - name: ibmmq + image: icr.io/ibm-messaging/mq:9.4.0.26-r2 + imagePullPolicy: IfNotPresent + env: + - name: LICENSE Review Comment: @oscerd I'd like your help to double check this point. I had a look and I think we're fine as this is a single user CICD workflow used for testing scope only. ########## e2e/keda/files/keda-it-ibmmq-to-log-auto.yaml: ########## @@ -0,0 +1,85 @@ +# --------------------------------------------------------------------------- +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# --------------------------------------------------------------------------- + +apiVersion: camel.apache.org/v1 +kind: Integration +metadata: + name: keda-it-ibmmq-to-log-auto +spec: + dependencies: + - camel:jms + - mvn:com.ibm.mq:com.ibm.mq.jakarta.client:9.4.0.26 Review Comment: @oscerd same for this lib, I think we should be fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
