squakez commented on code in PR #6914: URL: https://github.com/apache/camel-k/pull/6914#discussion_r4493637114
########## e2e/keda/keda_aws2_sqs_test.go: ########## @@ -0,0 +1,106 @@ +//go:build integration +// +build integration + +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package keda + +import ( + "context" + "testing" + + . "github.com/onsi/gomega" + . "github.com/onsi/gomega/gstruct" + corev1 "k8s.io/api/core/v1" + + . "github.com/apache/camel-k/v2/e2e/support" + v1 "github.com/apache/camel-k/v2/pkg/apis/camel/v1" +) + +func TestAws2SqsKedaAutoscale(t *testing.T) { + WithExistingNamedTestNamespace(t, func(ctx context.Context, g *WithT, ns string) { Review Comment: Better use a random namespace in order to let the testing framework delete the resources when test is complete. If you need to change on the fly the content of the testing route, then add a placeholder chars that can be replaced when running the test. For example, see how we're doing in https://github.com/apache/camel-k/blob/cf91c72ae815f30fd0689a7deb9288608e10b1c3/e2e/common/traits/kamelet_test.go#L139 in order to use the dynamic namespace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
