aldettinger opened a new pull request, #9458: URL: https://github.com/apache/camel-quarkus/pull/9458
Adds the MCP tool cases the suite left unverified, and untangles the tool name collision fixture. * `testCamelToolCollidingWithAnnotatedToolIsRefused` — a dedicated `clashing_tool` `@Tool` and an auto started `ai-tool` route asking for the same name. Auto started on purpose: that is the case which used to fail the application startup. Both implementations answer with a string naming the side that served the call, so the assertion reads off which one kept the name. The collision used to reuse `add_numbers`, entangling it with the coexistence test, which now has `add_numbers` to itself. * `testCallToolMissingRequiredArgument` — pins the documented contract that an argument error returns the validation message, unlike an execution error which is replaced by a generic one. * `testToolWithoutAnnotationHintsPublishesNone` — the negative counterpart of `testToolAnnotationHintsArePublished`. The quarkiverse annotations record uses primitive booleans, so publishing it for a tool that sets no hint would advertise the MCP defaults as if they had been chosen deliberately. Also asserts `annotated_tool`, `unannotated_tool` and `create_order` in the tag selection test, and documents that the tags only select `ai-tool` routes, plus what happens when an `ai-tool` route asks for a name a tool of the application already owns. ### Verification `integration-tests/mcp-server` is skipped on this branch (`skipTests`/`quarkus.build.skip`, see #9362), so **a green CI here does not mean these tests passed** — only that they compile. They were run on the `3.40.x` line, where the module is enabled and where the same three test methods are textually identical: 13 tests, 0 failures. A `[3.40.x]` backport PR will follow, carrying these tests plus the engine fix that this branch already has from #9300. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
