gnodet-bot commented on code in PR #29392: URL: https://github.com/apache/camel/pull/29392#discussion_r4503880511
########## dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ChaosVerdict.java: ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.dsl.jbang.core.commands; + +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.List; + +import org.apache.camel.dsl.jbang.core.common.CliExitCode; +import org.apache.camel.dsl.jbang.run.common.Printer; +import org.apache.camel.util.json.DeserializationException; +import org.apache.camel.util.json.JsonObject; +import org.apache.camel.util.json.Jsoner; + +/** + * The verdict of the chaos rules as the exit code of camel run --chaos (CAMEL-26722), so chaos can gate a pipeline: + * camel-chaos writes its report to a file when the run ends (camel.chaos.reportFile), and a run that ended well ends + * with exit code 1 when the verdict is FAIL. Without an expectation there is no verdict, which a line says. + */ +final class ChaosVerdict { + + private ChaosVerdict() { + } + + /** + * The exit code of the run with the verdict of the report. + * + * @param file the report that camel-chaos wrote when the run ended + * @param exitCode the exit code of the run + * @param printer where the verdict is said + * @return 1 when the run ended with 0 and the verdict is FAIL, else the exit code of the run + */ + static int apply(Path file, int exitCode, Printer printer) { + JsonObject report = read(file); + if (report == null) { + // chaos was off, or the run did not get as far as starting Camel + return exitCode; + } + List<Object> rules = report.getCollection("rules"); + if (rules == null || rules.isEmpty()) { + // no rule was added: nothing to say + return exitCode; + } + if ("FAIL".equals(report.getString("verdict"))) { + StringBuilder sb = new StringBuilder("Chaos verdict: FAIL"); + List<Object> reasons = report.getCollection("reasons"); + if (reasons != null) { + reasons.forEach(r -> sb.append("\n ").append(r)); + } + printer.printErr(sb.toString()); + return exitCode == CliExitCode.OK ? CliExitCode.FAILURE : exitCode; + } + int decided = 0; + int cancelled = 0; + for (Object o : rules) { + JsonObject expectation = (JsonObject) ((JsonObject) o).get("expectation"); Review Comment: 💡 **Minor defensive coding note:** The two casts on this line are unguarded — `(JsonObject) o` and `(JsonObject) ...get("expectation")` will both throw `ClassCastException` if the report JSON is corrupted or hand-edited so that an `rules` array element is not a JSON object (or if `"expectation"` maps to a non-object). The `read()` method catches `ClassCastException` for the root deserialization, but `apply()` has no such guard, and `withChaosVerdict()` calls `apply()` without a try/catch — so a malformed file produces an uncaught stack trace. Consider a defensive check: ```suggestion if (!(o instanceof JsonObject rule)) { continue; } JsonObject expectation = (JsonObject) rule.get("expectation"); ``` Or wrap the loop body in a try/catch mirroring `read()`. Low priority since users rarely hand-edit report files, but worth the guard given the asymmetry with the existing catch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
