davsclaus commented on code in PR #29344:
URL: https://github.com/apache/camel/pull/29344#discussion_r4501559458
##########
components/camel-activemq/src/main/java/org/apache/camel/component/activemq/ActiveMQComponent.java:
##########
@@ -258,7 +270,17 @@ protected void doStop() throws Exception {
}
singleConnectionFactoryList.clear();
- super.doStop();
+ super.doShutdown();
+ }
+
+ private static void invokePooledConnectionFactory(Object
pooledConnectionFactory, String method) {
+ try {
+ // invoke the method if it exists
+ Method m = pooledConnectionFactory.getClass().getMethod(method);
+ org.apache.camel.support.ObjectHelper.invokeMethod(m,
pooledConnectionFactory);
+ } catch (Exception e) {
+ // ignore
+ }
Review Comment:
@Croway this note and its twin in camel-activemq6 are the only open items on
this PR. Do you want to split the catch (`NoSuchMethodException` silent, the
rest logged at DEBUG), or keep it as is? Either way, please reply or resolve so
the PR can be merged.
_Claude Code on behalf of davsclaus_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
