mgubaidullin commented on PR #1664:
URL: https://github.com/apache/camel-karavan/pull/1664#issuecomment-6750843986
Thanks for putting this together, @bartoszpop. The tests are great and the
PR builds cleanly.
We'd like to hold off on merging, though, and explain why #889 suggests
cloning a Kamelets repository locally and pointing Karavan.kameletsPath at it.
A local clone gives us the things a shared catalog needs, and Karavan
doesn't have to implement any of them:
- Access control. Git already handles keys, tokens and SSO, which matters
for private catalogs.
- Versioning. Teams can pin a tag or branch, review changes and roll back.
- Designer and runtime stay in sync. The same folder is used by the designer
and by Camel JBang (--local-kamelet-dir), so what you see in the designer is
what runs.
Loading from a URL can't offer authentication or versioning. Because Camel
JBang can't use a URL, it also means splitting the configuration into two
settings. The designer could then show Kamelets the runtime can't find, and
existing setups would stop passing --local-kamelet-dir without anyone noticing.
That said, two parts of this PR would be really welcome as a smaller,
separate PR:
- Parsing the catalog as YAML documents instead of split("\n---\n"). This
fixes loading the built-in catalog on Windows, where files have CRLF line
endings.
- The Custom only fix, so the selected categories are kept when the toggle
is switched on.
Thanks again, and happy to help with the follow-up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
