vineetsaurabh commented on PR #29489: URL: https://github.com/apache/camel/pull/29489#issuecomment-6766608806
> Re-review of [c8d4634](https://github.com/apache/camel/commit/c8d4634c5ded96579ceed62a917ffe26c38ebfb3)..[4701e30](https://github.com/apache/camel/commit/4701e30fe143ea5550ef5e56c882264d292b3c64): > > The only new commit is gnodet's "Regen". It puts `camel-jbang-configuration-metadata.json` back to what main has, so blocker 1 of my earlier review is done. Nothing else changed, so my other points still apply: the `MojoHelper.getComponentPath()` entry in the `"camel-azure"` case (without it the catalog JSON, `components.properties`, Endpoint/Component DSL builders and catalog docs copy are not generated; "Build and test" passes only because that step is skipped), device identity vs. pool key, the ignored `send` return value in `IoTHubProducer.process`, `firstVersion`/`:since:` should be `4.24.0`/`4.24`, and the test items (FQCNs, `Thread.sleep` in `DeviceClientPoolTest`, `camel-test-junit5` → `camel-test-junit6`). I also agree with gnodet-bot's open threads, in particular `secret = true` on the `CamelAzureIoTHubConnectionString` header and the evictor race in `DeviceClientPool`. > > **New: PR doc validation fails** (run 42648775849). The site build treats any warning as a failure, and the log does not print the warning, but the page differs from the generated sibling pages in three ways: > > * it includes `component-endpoint-headers.adoc` twice (inside `// component options: START/END` and again after the empty `// endpoint options` markers); > * it has the empty legacy `// component-configure options: START/END` and `// endpoint options: START/END` blocks; > * it ends with `include::spring-boot:partial$starter.adoc[]`, but there is no `camel-azure-iothub-starter`. > > Could the options section match `azure-eventgrid-component.adoc` (a single `// component options: START/END` block with the three includes), and drop the starter include? You can check locally with apache/camel-website checked out next to camel: `yarn install` there, then `cd camel/docs && ./local-build.sh quick`. > > _Reviewed with Claude Code on behalf of davsclaus. This review was generated by an AI agent and may contain inaccuracies; please verify all suggestions before applying._ Incorporated in commit - 3a4689e55a0029af26b55f37e6287c983cc299de -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
