gnodet-bot commented on code in PR #29648: URL: https://github.com/apache/camel/pull/29648#discussion_r4540376496
########## docs/user-manual/modules/ROOT/pages/camel-3x-upgrade-guide-3_9.adoc: ########## @@ -24,7 +24,7 @@ the older APIs. For these 3rd party components to support recycling exchanges, t A new `org.apache.camel.spi.ResourceLoader` has been introduced as part of https://issues.apache.org/jira/browse/CAMEL-16285[CAMEL-16285] which provide a way to support additional schemas to resolve resources. As a consequece: Review Comment: ⚠️ Typo: `consequece` → `consequence` ```suggestion A new `org.apache.camel.spi.ResourceLoader` has been introduced as part of https://issues.apache.org/jira/browse/CAMEL-16285[CAMEL-16285] which provide a way to support additional schemas to resolve resources. As a consequence: ``` ########## docs/user-manual/modules/ROOT/pages/camel-3x-upgrade-guide-3_9.adoc: ########## @@ -156,7 +156,7 @@ The camel-jclouds feature for Camel on Karaf has been removed. === camel-kafka The camel-kafka consumer has been improved to be more roboust and have more confirations how to deal with exceptions while polling from Kafka Brokers. Review Comment: ⚠️ Two typos: `roboust` → `robust`, `confirations` → `configurations` ```suggestion The camel-kafka consumer has been improved to be more robust and have more configurations how to deal with exceptions while polling from Kafka Brokers. ``` ########## docs/user-manual/modules/ROOT/pages/camel-3x-upgrade-guide-3_9.adoc: ########## @@ -24,7 +24,7 @@ the older APIs. For these 3rd party components to support recycling exchanges, t A new `org.apache.camel.spi.ResourceLoader` has been introduced as part of https://issues.apache.org/jira/browse/CAMEL-16285[CAMEL-16285] which provide a way to support additional schemas to resolve resources. As a consequece: -- `org.apache.camel.support.ResourceHelper` has been updated to use such mechanism instead fo the old one. +- `org.apache.camel.support.ResourceHelper` has been updated to use such mechanism instead of the old one. - it is not more possible to provide support for additional schemas using the URL protocol handler mechanism but instead, custom schemas can be added by implementing `org.apache.camel.spi.ResourceResolver` and either bind an instance to the Camel Registry (using `resource-loader-` as a prefix) or using the Service Factory mechanism (under the path `META-INF/services/org/apache/camel/resource-resolver/`) As example, assuming you want to provide a support for the schema `foo`, then you either have to binbd your instance to the Camel Registry with `resource-loader-foo` as a key, or create a factory finder file with path `META-INF/services/org/apache/camel/resource-resolver/foo` Review Comment: ⚠️ Typo: `binbd` → `bind` ```suggestion As example, assuming you want to provide a support for the schema `foo`, then you either have to bind your instance to the Camel Registry with `resource-loader-foo` as a key, or create a factory finder file with path `META-INF/services/org/apache/camel/resource-resolver/foo` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
