gnodet-bot commented on code in PR #29653:
URL: https://github.com/apache/camel/pull/29653#discussion_r4540831585
##########
dsl/camel-jbang/camel-jbang-plugin-tui/src/main/resources/tui/help/endpoints.md:
##########
@@ -49,8 +49,8 @@ The left box lists all inbound components (consumers), the
right
box lists all outbound components (producers). The integration
name sits in the middle, showing the overall message flow direction.
-The numbers, and the in and out of the throughput chart, are the
-messages that come into the integration and go out of it. An endpoint
+The numbers, the in and out of the throughput chart, and the avg body
+chart are of the messages that come into the integration and go out of it. An
endpoint
Review Comment:
Nit: "chart" is stranded at the start of line 53, breaking the sentence.
```suggestion
The numbers, the in and out of the throughput chart, and the avg body chart
are the messages that come into the integration and go out of it. An endpoint
```
##########
dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/HistoryTab.java:
##########
@@ -740,10 +741,27 @@ public void refreshWhileVisible() {
if (historyRefreshRequested || historyFollow) {
historyRefreshRequested = false;
historyEntries = data.loadHistoryData(pids);
+ redrawHistoryDiagram();
}
data.refreshTraceData(pids);
}
+ /**
+ * The Diagram view draws the exchange of the history as it was when the
view opened: when the history was read
+ * again and is another exchange now, the diagram is drawn for that one,
so the screen and the table agree
+ * (CAMEL-26864).
+ */
+ private void redrawHistoryDiagram() {
Review Comment:
Fix #2 (`redrawHistoryDiagram`) is the only one in this batch without a
dedicated unit test. The logic is simple enough that a test verifying the
stale-diagram-reload on `onTabSelected` would be easy to add alongside
`HistoryTabRenderTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
