Dhairya-007 commented on PR #29642:
URL: https://github.com/apache/camel/pull/29642#issuecomment-6802137035
Thanks — both fixed in the last push.
1. **The catalog copy is back in sync.** `decyption` was corrected on the
component page only, which left
`catalog/.../docs/crypto-dataformat.adoc:18` behind and would have failed
the uncommitted-changes check, exactly as you said. I re-copied both
affected pages from their source and then diffed all 12 catalog copies
this PR touches — every one is byte-identical to its source page now.
2. **`hazelcast-pncounter`**: "but it does replicates most of the
functionality" now reads "does replicate", in both copies.
3. On `cyphertext` — agreed, it is a valid variant rather than an error. I
kept the change for the reason you give: the same page writes "Cipher" at
lines 124 and 150, matching the JCE class, so the page is now consistent
with itself.
The lesson I've taken from this one: accepting a suggestion on the component
page through the web UI silently breaks the mirror, because the catalog copy
is a committed duplicate rather than something the build derives at review
time. I'll apply those locally and re-copy from now on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]