davsclaus opened a new pull request, #29659:
URL: https://github.com/apache/camel/pull/29659

   The "two ids" part of item 15 of 
[CAMEL-26864](https://issues.apache.org/jira/browse/CAMEL-26864) (the rest is 
#29658).
   
   The trace said nodeId `from1` for the from of route hello, while 
`tui_get_processor_detail` said its id is `hello`. The from has a node id of 
its own (`from1`, or the id given to it), and the tracer, the message history 
and the backlog debugger name it by that. The `processor-detail` developer 
console named it by the route id instead, which is already the `routeId` of its 
response.
   
   - camel-console: the route input of `processor-detail` (`type: from`) has 
the id of the from, read from the route dump as the other processors are. The 
route id stays when the dump has no id for the from. The field description, its 
generated JSON and the catalog copy say so.
   - camel-jbang TUI: the Diagram draws the from as the route's node, named by 
the route id (as the route structure has it), so its detail panel finds the 
from by the route id too. That also keeps it working with an app on an older 
Camel.
   - Upgrade guide 4.24: the changed id in the console's JSON.
   
   The route structure (`route-structure` console, `ModelToStructureDumper`) 
still names the from line by the route id: that id is how the console reads the 
route statistics of the line, and how the Diagram and the Source tab find the 
route, so changing it would ripple far for no gain to a user.
   
   Tests: `ProcessorDetailFromIdTest` (camel-console, with JMX; fails without 
the fix: `expected: <from1> but was: <myRoute>`), `DiagramDetailFromIdTest` 
(TUI).
   
   _Claude Code on behalf of Claus Ibsen_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to