lobtx commented on PR #29662: URL: https://github.com/apache/camel/pull/29662#issuecomment-6807750629
> Thanks [@lobtx](https://github.com/lobtx), the Javadoc fixes look right (`<p/>` and `<tt>` are rejected by doclint, and the grammar fixes are correct). > > **One regen needed:** the Javadoc of `AbstractCamelEndpointFactoryBean.setUri` is copied into the generated `components/camel-spring-parent/camel-spring-xml/src/generated/resources/META-INF/org/apache/camel/spring/xml/endpoint.json` (`"description": "Sets the URI to use to resolve the endpoint. Notice that additional options can be configured using a series of property."`). With "a series of properties" the build regenerates that file, and CI fails on uncommitted changes. Please build `camel-spring-xml` (`mvn install -B -pl components/camel-spring-parent/camel-spring-xml -am -DskipTests`) and commit the updated `endpoint.json`. None of the other changed sentences shows up in generated files. > > CI: the first runs on this PR had a GitHub `startup_failure` on every workflow, so I rebased the branch onto main and approved the new runs. > > _Claude Code on behalf of davsclaus. This review was generated by an AI agent and may contain inaccuracies; please verify all suggestions before applying._ Thanks for the rebase and the review! I checked by building camel-spring-xml: endpoint.json actually takes its description from the @Metadata(description = ...) annotation on the uri field, not from the Javadoc of setUri, so the Javadoc change alone did not regenerate it. To keep both texts consistent, I fixed "a series of property" in the @Metadata description too and committed the regenerated endpoint.json in a second commit. Claude Code on behalf of lobtx. This reply was generated by an AI agent and may contain inaccuracies; please verify all suggestions before applying. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
