gnodet-bot commented on code in PR #29720:
URL: https://github.com/apache/camel/pull/29720#discussion_r4550749817
##########
components/camel-ai/camel-docling/src/main/java/org/apache/camel/component/docling/DoclingConfiguration.java:
##########
@@ -52,7 +52,8 @@ public class DoclingConfiguration implements Cloneable {
private String ocrLanguage = "en";
@UriParam
- @Metadata(description = "Output format for document conversion",
defaultValue = "markdown",
+ @Metadata(description = "Output format for document conversion. The
html_split_page value is rejected when useDoclingServe is true, as
docling-serve returns no split pages, and the CLI operations pass their own
format; use html instead",
+ defaultValue = "markdown",
Review Comment:
⚠️ `html_split_page` is still listed in `enums`, so the catalog and IDE
autocomplete will continue to present it as a valid choice. The description now
says it doesn't work, but users who rely on catalog-driven configuration rather
than reading the full description will still pick it and get unexpected
behaviour.
Consider removing it from `enums`, or throwing an explicit
`IllegalArgumentException` during configuration validation rather than silently
falling back to markdown (which is what the CLI path does in
`mapToDoclingFormat` — there is no case for `html_split_page`, so it defaults
to `"md"` without any warning).
```suggestion
@Metadata(description = "Output format for document conversion. The
html_split_page value is not supported"
+ " and will be removed in a future release; use
html instead.",
defaultValue = "markdown",
enums = "md,json,html,text,doctags")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
