This is an automated email from the ASF dual-hosted git repository.
tdiesler pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel-spring-boot.git
The following commit(s) were added to refs/heads/main by this push:
new 04972fc1baf CSB-13095: Fix camel-micrometer-observability-starter
fails startup with NPE when trace-processors is unset
04972fc1baf is described below
commit 04972fc1baf031bbc899f556f840357787825321
Author: Thomas <[email protected]>
AuthorDate: Mon Nov 2 19:35:15 2026 +0100
CSB-13095: Fix camel-micrometer-observability-starter fails startup with
NPE when trace-processors is unset
- traceProcessors was a boxed Boolean with no default, so unset caused NPE
on unboxing in isTraceProcessors()
- Revert field to primitive boolean so it defaults to false as documented
- Add auto-configuration test covering startup with trace-processors unset
Co-Authored-By: Claude Sonnet 5 <[email protected]>
---
.../src/main/docs/micrometer-observability.json | 3 +-
...ometerObservabilityConfigurationProperties.java | 2 +-
...crometerObservabilityAutoConfigurationTest.java | 41 ++++++++++++++++++++++
.../pages/starters/micrometer-observability.adoc | 2 +-
4 files changed, 45 insertions(+), 3 deletions(-)
diff --git
a/components-starter/camel-micrometer-observability-starter/src/main/docs/micrometer-observability.json
b/components-starter/camel-micrometer-observability-starter/src/main/docs/micrometer-observability.json
index d37bbe0e529..2d894bcadb7 100644
---
a/components-starter/camel-micrometer-observability-starter/src/main/docs/micrometer-observability.json
+++
b/components-starter/camel-micrometer-observability-starter/src/main/docs/micrometer-observability.json
@@ -30,7 +30,8 @@
"name": "camel.micrometer.observability.trace-processors",
"type": "java.lang.Boolean",
"description": "Setting this to true will create new telemetry spans for
each Camel custom Processors. Use the excludePattern property to filter out
Processors.",
- "sourceType":
"org.apache.camel.micrometer.observability.starter.MicrometerObservabilityConfigurationProperties"
+ "sourceType":
"org.apache.camel.micrometer.observability.starter.MicrometerObservabilityConfigurationProperties",
+ "defaultValue": false
}
],
"hints": [],
diff --git
a/components-starter/camel-micrometer-observability-starter/src/main/java/org/apache/camel/micrometer/observability/starter/MicrometerObservabilityConfigurationProperties.java
b/components-starter/camel-micrometer-observability-starter/src/main/java/org/apache/camel/micrometer/observability/starter/MicrometerObservabilityConfigurationProperties.java
index eecb92ca76d..aeb07f951c1 100644
---
a/components-starter/camel-micrometer-observability-starter/src/main/java/org/apache/camel/micrometer/observability/starter/MicrometerObservabilityConfigurationProperties.java
+++
b/components-starter/camel-micrometer-observability-starter/src/main/java/org/apache/camel/micrometer/observability/starter/MicrometerObservabilityConfigurationProperties.java
@@ -35,7 +35,7 @@ public class MicrometerObservabilityConfigurationProperties {
* Setting this to true will create new telemetry spans for each Camel
custom Processors. Use the excludePattern
* property to filter out Processors.
*/
- private Boolean traceProcessors;
+ private boolean traceProcessors;
/**
* Disable any inner core processors (any core DSL processor provided in
the route, for example `bean`, `log`, ...).
*/
diff --git
a/components-starter/camel-micrometer-observability-starter/src/test/java/org/apache/camel/micrometer/observability/starter/MicrometerObservabilityAutoConfigurationTest.java
b/components-starter/camel-micrometer-observability-starter/src/test/java/org/apache/camel/micrometer/observability/starter/MicrometerObservabilityAutoConfigurationTest.java
new file mode 100644
index 00000000000..c7ff136febe
--- /dev/null
+++
b/components-starter/camel-micrometer-observability-starter/src/test/java/org/apache/camel/micrometer/observability/starter/MicrometerObservabilityAutoConfigurationTest.java
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.micrometer.observability.starter;
+
+import org.apache.camel.micrometer.observability.MicrometerObservabilityTracer;
+import org.apache.camel.spring.boot.CamelAutoConfiguration;
+import org.junit.jupiter.api.Test;
+import org.springframework.boot.autoconfigure.AutoConfigurations;
+import org.springframework.boot.test.context.runner.ApplicationContextRunner;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+class MicrometerObservabilityAutoConfigurationTest {
+
+ private final ApplicationContextRunner runner = new
ApplicationContextRunner()
+
.withConfiguration(AutoConfigurations.of(CamelAutoConfiguration.class,
MicrometerObservabilityAutoConfiguration.class))
+ .withPropertyValues("spring.main.banner-mode=off");
+
+ @Test
+ void testStartsWithoutTraceProcessorsConfigured() {
+ runner.run(context -> {
+ assertThat(context).hasNotFailed();
+
assertThat(context).hasSingleBean(MicrometerObservabilityTracer.class);
+
assertThat(context.getBean(MicrometerObservabilityTracer.class).isTraceProcessors()).isFalse();
+ });
+ }
+}
diff --git
a/docs/spring-boot/modules/ROOT/pages/starters/micrometer-observability.adoc
b/docs/spring-boot/modules/ROOT/pages/starters/micrometer-observability.adoc
index cf9cad1fcae..74c38272920 100644
--- a/docs/spring-boot/modules/ROOT/pages/starters/micrometer-observability.adoc
+++ b/docs/spring-boot/modules/ROOT/pages/starters/micrometer-observability.adoc
@@ -29,5 +29,5 @@ The starter supports 4 options, which are listed below.
| camel.micrometer.observability.disable-core-processors | Disable any inner
core processors (any core DSL processor provided in the route, for example
`bean`, `log`, ...). | false | Boolean
| camel.micrometer.observability.exclude-patterns | Sets exclude pattern(s)
that will disable tracing for Camel processors that matches the pattern.
Multiple patterns can be separated by comma. | | String
| camel.micrometer.observability.include-patterns | Sets include pattern(s)
that will explicitly enable tracing for Camel processors that matches the
pattern. Multiple patterns can be separated by comma. All processors included
by default if nothing is specified. | | String
-| camel.micrometer.observability.trace-processors | Setting this to true will
create new telemetry spans for each Camel custom Processors. Use the
excludePattern property to filter out Processors. | | Boolean
+| camel.micrometer.observability.trace-processors | Setting this to true will
create new telemetry spans for each Camel custom Processors. Use the
excludePattern property to filter out Processors. | false | Boolean
|===
