oscerd opened a new pull request, #176:
URL: https://github.com/apache/camel-kit/pull/176
Closes #145.
`camel-validate/guides/endpoint-validation.md` Stage 3 told the agent to run
`camel run --check {ROUTE_FILE} {PROPS_FILE}`. The Camel CLI has no `--check`
option on `camel run` (checked against `camel run --help` on Camel JBang
4.22.0, matching the report against 4.22.1), so the stage failed on every run.
## What changed
- **Stage 3 is now a static hand-off, not a command.** `/camel-validate` is
documented as a static gate that "writes a report and changes nothing", with
runtime failures belonging to the `/camel-execute` verification loop
(`docs/modules/ROOT/pages/camel-validate.adoc`). The stage now says so and maps
each concern the old command claimed to cover to where it is actually checked:
YAML parsing (Stage 1), component existence and endpoint options (Stage 2),
property placeholders (`quality-checks.md` §7.2), bean references (§7.3), and
startup, dependency and connection failures (the verification loop, recorded as
the `Verification:` line of `execution-report.md`; `/camel-debug` outside a
pipeline). It prints a `== RUNTIME VALIDATION ==` hand-off that quotes that
line when the run is pipeline-scoped and says "not available" in a
project-scoped run.
- `ResourceConsistencyTest` now asserts that the guide contains no `camel
run --check` and no shell block at all, and pins the hand-off text.
- The Kit README and the Antora getting-started prerequisites no longer
advertise `camel run --check`; Camel JBang stays a prerequisite for `camel run`
in the verification loop.
- CHANGELOG entry under *Fixed*.
## Why the command was not replaced
- `camel run --stub=all --max-seconds=N` was probed on Camel 4.22.0 with a
timer→kafka route and a properties file: it catches a broken YAML file, an
undefined placeholder and a missing bean, but silently accepts an unknown
endpoint option (`kafka:...?bogusOption=1` started fine under `--stub=all`;
without the stub it fails with "parameters that couldn't be set"). It also
downloads dependencies and runs code, which contradicts the static contract and
duplicates the verification loop that already runs the routes with `camel run`.
- The Camel 4.18+ `validate` plugin (`camel plugin add validate`, `camel
validate yaml …`) is the same YAML DSL validator that Stage 1 already runs
through `camel-yaml-dsl-validator:validate`, so it adds no coverage.
- The placeholder and bean checks the old stage claimed already exist
statically in `quality-checks.md` 7.2 and 7.3.
## Verification
- `ResourceConsistencyTest` and `ShippedAssetStructureTest` pass; `./mvnw -B
-Psourcecheck validate` passes.
- Full reactor `./mvnw clean install -B` with tests: BUILD SUCCESS for all
13 modules (13:22 min), run with `LC_ALL=C`. A first run under this machine's
Italian locale failed only in the pre-existing
`LocalCommandRunnerTest.boundsGitDiscoveryToTheWorkingDirectory`, which asserts
on git's English stderr text ("not a git repository") while the exit-code check
already passed; that test is unrelated to this change and passes under an
English locale. Making it locale-independent would be a separate small fix.
Website impact: required — the prerequisites row of
`docs/modules/ROOT/pages/getting-started.adoc` changed.
_AI-generated by Claude Code (Claude Fable 5.1) on behalf of @oscerd._
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
