davsclaus opened a new pull request, #29769:
URL: https://github.com/apache/camel/pull/29769

   ## Backport of #29731
   
   Cherry-pick of #29731 onto `camel-4.18.x`.
   
   **Original PR:** #29731 - CAMEL-26485: camel-netty-http - endpoint options 
are no longer sent to the server as query parameters
   **Original author:** davsclaus
   **Target branch:** `camel-4.18.x`
   **JIRA:** [CAMEL-26485](https://issues.apache.org/jira/browse/CAMEL-26485) 
(fix version 4.18.6)
   
   ### Straight or adapted
   
   Adapted. The new test `NettyHttpEndpointOptionsNotInQueryTest` is identical 
to #29731. The difference is in `NettyHttpComponent.createEndpoint`:
   
   - On `main`, CAMEL-26487 split the endpoint URI (the full URI with the 
options) from a separate address URI (the http address to call), and #29731 
builds the address URI after `setProperties` has bound and removed the endpoint 
options.
   - On `camel-4.18.x`, the CAMEL-26487 backport keeps the address as the 
endpoint URI (`HttpClientInitializerFactory` and `NettyHttpHelper` call 
`getEndpointUri()`) and the full URI as the identity (`setIdentityUri`). So the 
endpoint is now created with the full URI, and once the options are bound its 
endpoint URI is set to the address through a new package-private 
`NettyHttpEndpoint.setAddressUri`, which calls `setEndpointUri`.
   - The upgrade-guide note is left out: the 4.22.3 and 4.18.6 notes are added 
on `main` in #29765.
   
   Built and tested on this branch: the whole `camel-netty-http` module passes, 
including `NettyHttpEndpointOptionsNotInQueryTest` (3 tests).
   
   _Claude Code on behalf of davsclaus_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to