DakshinJeeva commented on PR #29505: URL: https://github.com/apache/camel/pull/29505#issuecomment-6844208673
Hi @davsclaus , I've addressed the review feedback and updated the PR. The changes include: - Reworked optimistic removal with a Lua script to atomically compare the active exchange, persist it to the recovery map, and remove it from the active map. - Removed the duplicate serialized holder argument from the Lua script invocation. - Added Redis Cluster hash-slot validation when optimistic removal and recovery are enabled. - Added documentation explaining the hash-tag requirement and updated the Camel 4.24 upgrade guide. - Added four regression tests covering recovery write failure, stale removal, concurrent removal, and incompatible Redis Cluster hash slots. - Updated the PR description and clarified the Lua script's behavior. I've also run the `camel-redis` module verification successfully. Could you please take another look at the updated implementation and let me know if anything else needs to be addressed? Thank you for your feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
