allthingssecurity commented on PR #29790:
URL: https://github.com/apache/camel/pull/29790#issuecomment-6847913071
Thanks for the review. Done in 9ad76ce27a27:
1. `${hash()}` now hashes the body with SHA-256, as documented: an empty
argument list is one argument left out (your sketch), so it behaves as
`${hash(,)}`. `testArgumentLeftOutWithADefault` has the
`assertEquals(evaluate("hash(${body})", ...), evaluate("hash()", ...))` line,
and the 4.24 upgrade guide entry has one sentence on it.
2. Right, a whitespace-only first argument was kept as empty text on main
(`${concat( ,x)}` gave `x`, now the body followed by `x`). I did not touch the
commit; the wording is corrected in the PR description, so the squash message
can use that.
3. Dropped `${pad(len)} or ` from the first guard message of `pad`.
Also took the gnodet-bot readability suggestion: `concat` uses a named
`expIdx` instead of the ternary in the subscript. No change for
`createFactory()`, as you explained.
Simple language tests: 740 run, 0 failures. The PR description is updated.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
