gnodet-bot commented on code in PR #29803:
URL: https://github.com/apache/camel/pull/29803#discussion_r4561844898
##########
components/camel-openfga/pom.xml:
##########
@@ -33,8 +33,7 @@
<description>Camel OpenFGA Component</description>
<properties>
- <!-- the openfga/openfga image is only published for amd64 and arm64
-->
- <skipITs.ppc64le>true</skipITs.ppc64le>
+ <!-- the openfga/openfga image is published for amd64, arm64, and
ppc64le -->
Review Comment:
💡 **Inaccurate comment** — the `openfga/openfga` image is NOT published for
ppc64le; ppc64le uses a separate image from IBM Container Registry
(`icr.io/ppc64le-oss/openfga-ppc64le`). The comment implies the upstream image
supports ppc64le, which is false. Also, the double space before `published` is
a typo.
```suggestion
<!-- s390x is skipped because openfga/openfga is only published for
amd64 and arm64; ppc64le uses a separate image from ICR (see
container.properties) -->
```
##########
test-infra/camel-test-infra-openfga/src/main/resources/org/apache/camel/test/infra/openfga/services/container.properties:
##########
@@ -15,3 +15,4 @@
## limitations under the License.
## ---------------------------------------------------------------------------
openfga.container=mirror.gcr.io/openfga/openfga:v1.22.1
+openfga.container.ppc64le=icr.io/ppc64le-oss/openfga-ppc64le:1.21.0
Review Comment:
💡 **Missing pin comment** — ppc64le is running 1.21.0 while the main image
is at v1.22.1. Add a brief comment explaining the pin (consistent with the
docling pattern used elsewhere in test-infra), so future bumps don't silently
leave ppc64le on an older version.
```suggestion
# pin to the latest available ppc64le image (lags behind the main tag)
openfga.container.ppc64le=icr.io/ppc64le-oss/openfga-ppc64le:1.21.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
