allthingssecurity commented on PR #29785: URL: https://github.com/apache/camel/pull/29785#issuecomment-6847803846
Thanks for the review. Done in 50dcbbbc3674, in this PR: 1. `submitCompletions` now catches `VirtualMachineError` (rethrown, left as before), then `RuntimeException | Error`: it keeps the first failure, sends the other aggregated exchanges, and throws the first failure after the loop (an `Error` as an `Error`, a `RuntimeException` as is), as in your sketch. `AggregateOnCompletionThrowsTest#testFailedBatchCompletionSendsOtherGroups` now runs with an `IllegalStateException` and with a `NoClassDefFoundError` from `onCompletion`. The `Error` variant fails without the change (the other group is not sent: 1 message instead of 2). 2. `testRecoverGoesOnAfterAnExchangeThatFailsAgain` is parameterized the same way, so the inner catch of the recover task is covered with an `Error` too. 3. Added the "left as before" comment to the inner `VirtualMachineError` catch of the recover task. Aggregator and timeout map tests: 252 run, 0 failures, 2 skipped. The PR description is updated. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
