allthingssecurity commented on PR #29901:
URL: https://github.com/apache/camel/pull/29901#issuecomment-6875731956

   Thanks @davsclaus, done in 06d24213ee83.
   
   1. **`camel debug --sanitizer`.** You are right, it was not handled: the 
still pending check knows nothing of the debugger, so a breakpoint inside a 
nested step would have been reported after a minute. Now, with the debugger on 
(`camel debug` runs `camel run` with `camel.debug.enabled=true`), the run sets 
`camel.sanitizer.pendingTimeout=0` as an initial property unless it is set on 
the command line or in the application properties. As an initial property it 
loses to any other setting of it. The other checks stay on. The sanitizer page 
has a paragraph on it. Test: `RunPipelineTest` (set with the debugger on, kept 
when given with `--prop` or in the application properties, not set without the 
debugger).
   2. **`report=false`.** The console has a `report` option (default `true`, as 
on `ChaosDevConsole`): with `false` the JSON has the fields and counts, without 
the report of each violation and without the still pending warnings. The 
connector action forwards it the way `doActionTimelineTask` forwards its 
options, and `loadSanitizer` asks with `report=false` unless `--report` is 
given. Tests: 
`SanitizerDevConsoleTest.withoutTheReportTheViolationsHaveTheirFieldsOnly` and 
`theStillPendingWarnings`, 
`LocalCliConnectorSanitizerActionTest.theReportsAreLeftOutWithReportFalse`, 
`ListSanitizerTest.theTableAsksWithoutTheReports`, `ListSanitizerActionTest` 
(the action file has `report=false`). The dev console metadata and the catalog 
copies (with the openapi file) are regenerated.
   3. **Older `--camel-version`.** Left out: doing it for `--sanitizer` only 
would differ from `--chaos`, which has the same gap, and it would change the 
golden case. A follow-up can add one usage check for both.
   4. **[Nit] kinds.** The kinds are now printed at the same level as the rule 
lines. `ListSanitizerTest` checks the indentation.
   5. **[Nit] all older than 4.24.** When every matched integration is older 
than Camel 4.24 the note now says camel-sanitizer is new in 4.24 and they are 
older, without suggesting `camel run --sanitizer`. 
`ListSanitizerTest.anIntegrationBeforeCamel424IsNotAsked`.
   
   Tests: camel-core sanitizer tests 124 (`SanitizerDevConsoleTest` 9), 
camel-management 1, camel-main 10, camel-test-main-junit6 4, 
camel-cli-connector 22 (`LocalCliConnectorSanitizerActionTest` 3, chaos action 
19), camel-jbang-run 32 (`RunPipelineTest` 11, `ProjectRunnerTest` 21), 
camel-jbang-core 91 (`ListSanitizerTest` 15, `ListSanitizerActionTest` 2, 
`ListChaosTest` 21, `RunTest` 27, `CommandInputErrorsTest` 24, 
`CliHelpGoldenTest` and `CliParseGoldenTest` pass without regenerating, as the 
help does not change), all 0 failures. The build regenerated the dev console 
metadata with no difference from what is committed. The PR description is 
updated to match.
   
   _Claude Code on behalf of allthingssecurity_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to