allthingssecurity commented on PR #29896:
URL: https://github.com/apache/camel/pull/29896#issuecomment-6876063646
Thanks @davsclaus, done in d2f62bd1ae3a.
1. **`VirtualMachineError` row.** Now reads "(a `VirtualMachineError` of an
`AggregationStrategy` or of the iterator of a split is thrown on from the task
of the EIP, ...)".
2. **`timeout(100)`.** Now `timeout(1000)` in `MulticastTaskThrowsErrorTest`.
3. **Question.** Folded in here. `onPrepare`
(`MulticastProcessor.createProcessorExchangePair` and the copy in
`RecipientListProcessor`) and `sync.process(exchange)` in
`MulticastTransactedTask.doRun` now set an `Error` that is not a
`VirtualMachineError` on the part, as an exception, so only that part fails and
it goes through the `stopOnException` rules like any failed part. A
`VirtualMachineError` is thrown on as before. This also fixes CAMEL-26952,
which I had filed for it; the description and the 4.24 guide paragraph say so.
Tests: new `OnPrepareThrowsErrorTest` (split, streaming split, recipient
list, split with `stopOnException`, and an exception as control), and in
`MulticastTaskThrowsErrorTest` a transacted multicast whose first part throws
an `AssertionError` straight to the task (the test turns off the wrapping of
the parts, as the unit of work and the step around a part already handle an
`Error`; this is the case of one that escapes them): the second part is still
sent and the exchange fails with the `Error`, with an exception as control.
Against the code of the PR head, the four onPrepare `Error` cases fail (the
exchange does not answer within 10 s) and the transacted `Error` case fails
(`the part after the failed part must still be sent ==> expected: <[second]>
but was: <[]>`); the controls pass.
4. Nit: left as is, `catch (Exception)` stays first so `doFailed(Exception)`
keeps getting the exceptions.
Tests: the `*Split*`, `*Multicast*` and `*RecipientList*` tests of
camel-core with the three test classes above: 685 run, 0 failures, 6 skipped, 1
error (`DumpModelAsYamlSplitNestedChoiceEndRouteTest`, `NoClassDefFoundError:
OgnlExpression` from a stale camel-yaml-io jar in my local repository,
unrelated); `OnPrepareThrowsErrorTest` 5, `MulticastTaskThrowsErrorTest` 10 and
`SiblingProcessorsThrowErrorTest` 10 pass on the final commit. The PR
description is updated to match.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]