gnodet-bot commented on code in PR #29972:
URL: https://github.com/apache/camel/pull/29972#discussion_r4575268430
##########
components/camel-pdf/src/main/java/org/apache/camel/component/pdf/PdfHeaderConstants.java:
##########
@@ -36,7 +36,10 @@ public final class PdfHeaderConstants {
Expected type is
https://pdfbox.apache.org/docs/2.0.13/javadocs/org/apache/pdfbox/pdmodel/encryption/DecryptionMaterial.html[DecryptionMaterial].
*Mandatory* header if PDF document is encrypted.""",
Review Comment:
⚠️ **Misleading description survives the deprecation**
This description still tells users the header is mandatory for encrypted
PDFs — which was never true. Update it to match reality:
```suggestion
*Deprecated.* This header has never been read by the component.
PDFBox 2+ decrypts documents at load time (via the password
argument to `Loader.loadPDF`);
by the time the producer receives a `PDDocument`, decryption has
already occurred or failed.
Use `Loader.loadPDF(bytes, password)` in a type converter or a
`Processor` before the PDF endpoint instead.""",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
