gnodet-bot commented on code in PR #30010:
URL: https://github.com/apache/camel/pull/30010#discussion_r4578165239


##########
core/camel-base/src/main/java/org/apache/camel/impl/converter/AnnotationTypeConverterLoader.java:
##########
@@ -322,6 +322,13 @@ protected boolean acceptClass(Class<?> clazz) {
         return true;
     }
 
+    /**
+     * Creates the injector that provides the instance the non-static 
converter methods of the given type are invoked on
+     */

Review Comment:
   💡 **Nit:** The Javadoc is a bit passive — "provides the instance" reads like 
the method always hands back a pre-existing object. The method actually 
*creates* an injector that will lazily instantiate the converter class on first 
use (unless overridden, as `TypeConvertersLoader` does). Consider:
   
   ```suggestion
       /**
        * Creates an injector that lazily instantiates the converter class on 
first invocation.
        * Override to supply a pre-built instance (see {@link 
TypeConvertersLoader}).
        */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to