Croway commented on PR #30011: URL: https://github.com/apache/camel/pull/30011#issuecomment-6896302066
@davsclaus 1. Done in 5606547: `onPredicateFailure`, `FinallyProcessor`, `OnCompletionProcessor`, `MulticastProcessor` (its target can be the instance, e.g. an aggregation strategy that returns the failed sub-exchange) and also `SagaProcessor` (compensation failure, same growth) no longer add to the shared instance. The last four log the other exception at WARN instead, as it would otherwise be lost. `SendHelper` is left as is: camel-support cannot see camel-core-processor without new public API, and it only adds when a send hook fails (same for `CompositeSendHook`, and `AdviceIterator` in camel-base-engine). The EIP page now lists what is not added. New tests send 3 messages through each path (2 for the saga) and fail without the change; `OnExceptionHandledThrowsExceptionTest`, `ErrorHandlerFailurePathsTest#testDeadLetterChannelRetryWhileThrows`, and the doFinally cases of `DoTryEdgeCasesTest`, `FailOverLoadBalanceSuppressedExceptionTest` and `ThrottlingExceptionRoutePolicySuppressedExcepti onTest` now use the type form. 2. Done: the PR description says this narrows CAMEL-11229 and why. The upgrade-guide entry already said why the error handler no longer adds the previous exception; it now also lists the other paths. 3. Done in 5606547: weak identity set filled in the constructor. `ref` is looked up once by `ThrowExceptionReifier` when the route is created, so the constructor sees that instance too. The marker now follows the exception: the property missed an instance thrown on a copy of the exchange, such as by the topic load balancer, which sets only the exception back (`testOnExceptionThrowsInstanceOnCopy` got 3 suppressed with the property). Weak keys, so a removed or reloaded route leaves nothing behind. It does not help `SendHelper`, as with the property. 4. Done in 5606547: `FatalFallbackErrorHandler` no longer reads `getSuppressed()[0]` of a shared instance as the previous exception. _Claude Code on behalf of Federico Mariani_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
