davsclaus opened a new pull request, #30036:
URL: https://github.com/apache/camel/pull/30036

   JIRA: [CAMEL-26934](https://issues.apache.org/jira/browse/CAMEL-26934), 
items 6 and 7 (part).
   
   - **`--profile` and the traits of `application.properties` (item 6).** 
`KubernetesExport` read the traits of `application-<profile>.properties` 
*instead of* those of `application.properties`. 
`camel-jbang-kubernetes-advanced.adoc` gives both, with the profile above 
`application.properties`. They are now merged that way 
(`TraitHelper.mergeTraits(profile, default)`).
   - **Annotations (item 6).**
     - `--trait ingress.annotations=k=v` (and `route.`, `knative-service.`) 
gave a string where the trait takes a map, so the export exited with 70 and a 
Jackson trace.
     - The form the docs show, 
`route.annotations.'haproxy.router.openshift.io/balance'=true`, was not read 
either: the whole `annotations.'…'` became the key of the trait.
     - Both forms now give an annotation, and the annotations of several 
`--trait` options add up.
     - The trait descriptions (`Route`, `KnativeService`) and 
`camel-jbang-kubernetes-advanced.adoc` show `--trait` instead of `-t`, which is 
not an option.
   - **Mount path on Windows (item 7).** `MountTrait` joined the mount path 
with `Path.of`, which gives backslashes on Windows, although it is a path in 
the container. It is now joined with `/`.
   - **"Custom container name … not supported" (item 7)** was printed on 
stdout, but the container trait applies the name. The message is removed.
   
   Tests:
   - `KubernetesExportTest.aProfileKeepsTheTraitsOfApplicationProperties`;
   - `TraitHelperTest.anAnnotationAsKeyValue` and `anAnnotationAsItsOwnKey`.
   
   All three fail on main. Kubernetes plugin suite: 168 tests, green.
   
   `TraitHelper` is also changed by #30024 (quoted trait values); whichever 
merges second may need main merged in.
   
   Left of items 6 and 7:
   - image settings;
   - `sanitize` (`my.app.v2` → `my`);
   - a Service and port 8080 for every workload;
   - `ingress.auto`;
   - `run --output yaml` contacting the cluster;
   - `--quiet` and the reasons of a failed export;
   - typos in trait names;
   - `--json` for `delete` and `logs`;
   - `delete` exiting 0 when nothing is found.
   
   _Claude Code on behalf of davsclaus_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to