Croway opened a new pull request, #30064:
URL: https://github.com/apache/camel/pull/30064

   Docs only. The HTTP component passes to HttpClient 5 only the timeouts set 
to a non-default value, so HttpClient's own defaults apply, and the page had 
only a link to a unit test about them. Fault-injection tests (a silently 
dropped connection, and an idle pooled connection closed or dropped by the 
server side) showed a request blocking for 3 minutes with the defaults, a 
`POST` failing with `NoHttpResponseException` on a connection the server had 
just closed, and a silently dropped idle connection being reused.
   
   **http-component.adoc**: the section "Using client timeout - SO_TIMEOUT" (a 
link to `HttpSOTimeoutTest`) is replaced by "Timeouts and dead or silent 
servers" (nothing in the docs links to the old anchor):
   - a table of `connectTimeout`, `soTimeout`, `responseTimeout` and 
`connectionRequestTimeout`, with HttpClient's defaults and what each bounds, 
and an example;
   - a timed-out request is not retried by HttpClient; `soTimeout` and 
`connectionTimeToLive` do not apply with a custom `clientConnectionManager`;
   - subsection "Pooled connections closed by the server or by a NAT": the 
2-second `validateAfterInactivity` (not exposed), idempotent-only retry of 
`NoHttpResponseException`, and the two settings that keep the pool from reusing 
a silently dropped idle connection: `httpClient.connectionKeepAlive` and 
`connectionTimeToLive`.
   
   The SSL, proxy and `useSystemProperties` sections and option descriptions 
are not touched.
   
   Checked against the sources at the versions on `main`: HttpClient 5.6.5 
(`RequestConfig`, `ConnectionConfig`, `PoolingHttpClientConnectionManager` 
lease and connect, `DefaultHttpClientConnectionOperator`, 
`InternalExecRuntime`, `DefaultHttpRequestRetryStrategy`, 
`DefaultConnectionKeepAliveStrategy`), HttpCore 5.4.4 (`SocketConfig`, 
`StrictConnPool`, `Method`), and Camel's `HttpComponent.createEndpoint` / 
`createConnectionManager` / `createHttpClientBuilder` and 
`HttpEndpoint.createHttpClient`. That `httpClient.connectionKeepAlive` binds 
and stops the reuse of an idle connection was also checked with a throwaway 
test against a local server (not committed). The durations are given as 
approximate behaviour of HttpClient. The catalog copy is regenerated.
   
   _Claude Code on behalf of Croway_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to