Dhairya-007 opened a new pull request, #30069:
URL: https://github.com/apache/camel/pull/30069

   ## Problem
   
   19 of the component's header `javaType` values name a class by its simple 
name, so the catalog publishes a type the reader cannot resolve:
   
   ```java
   @Metadata(label = "consumer", description = "Archive status of the blob.", 
javaType = "ArchiveStatus")
   public static final String ARCHIVE_STATUS = HEADER_PREFIX + "ArchiveStatus";
   ```
   
   ```json
   "CamelAzureStorageBlobArchiveStatus": { ..., "javaType": "ArchiveStatus", 
... }
   ```
   
   Fully qualified is the convention by a wide margin - across the whole 
catalog, 3692 header `javaType` values are fully qualified or a built-in type, 
and 151 are not. `azure-storage-blob` holds the second-largest share of those 
151.
   
   It matters most where the simple name is genuinely ambiguous:
   
   - `Duration` is `java.time.Duration`.
   - `OffsetDateTime` is `java.time.OffsetDateTime` - and the file already 
spells it that way for `CamelAzureStorageBlobImmutabilityPolicyExpiryTime`, so 
the same type is currently published under two different names.
   - `HttpHeaders` is `com.azure.core.http.HttpHeaders`, not the 
`BlobHttpHeaders` declared a few lines away.
   - `Context` is `com.azure.core.util.Context`, which is easy to read as 
Camel's own `CamelContext`-adjacent type.
   - `ParallelTransferOptions` is 
`com.azure.storage.blob.models.ParallelTransferOptions` here, while the sibling 
`camel-azure-storage-datalake` uses 
`com.azure.storage.common.ParallelTransferOptions` - the simple name alone does 
not say which.
   
   ## Fix
   
   Qualify all 19, taking each FQN from the import the module itself uses. 
Header names are untouched; only the documented type changes.
   
   Metadata only - no behaviour change. I diffed the regenerated catalog file 
against `main` and confirmed the 19 `javaType` values are the only fields that 
differ, with no header added or removed and no change to the option sections.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to