Dhairya-007 opened a new pull request, #30071:
URL: https://github.com/apache/camel/pull/30071

   ## Problem
   
   All 15 of the component's header `javaType` values name their AWS SDK model 
class by simple name only:
   
   ```java
   @Metadata(description = "A map of attribute names to AttributeValue objects, 
as specified by ReturnValues.",
             javaType = "Map<String, AttributeValue>")
   public static final String ATTRIBUTES = "CamelAwsDdbAttributes";
   ```
   
   ```json
   "CamelAwsDdbAttributes": { ..., "javaType": "Map<String, AttributeValue>", 
... }
   ```
   
   Fully qualified is the convention by a wide margin - across the whole 
catalog, 3692 header `javaType` values are fully qualified or a built-in type, 
and 151 are not.
   
   `AttributeValue` is a name worth being exact about: 
`software.amazon.awssdk.services.dynamodb.model.AttributeValue` is not the only 
`AttributeValue` an AWS user meets - 
`software.amazon.awssdk.services.dynamodb.streams.model.AttributeValue` exists 
in the DynamoDB Streams SDK that `camel-aws2-ddbstream` uses, and others ship 
in unrelated services. Every one of these headers carries a map or list of 
them, so a reader guessing wrong gets a compile error with no hint from the 
catalog.
   
   Worth noting while reading them side by side: `CamelAwsDdbUpdateValues` is 
the only one whose element type is `AttributeValueUpdate` rather than 
`AttributeValue`, which is far easier to see once the names are qualified.
   
   ## Fix
   
   Qualify all 15, taking each FQN from the import `Ddb2Constants`' own module 
uses. The `Map`, `List` and `String` spellings are left as they are, matching 
the rest of the catalog; only the model classes are qualified.
   
   Metadata only - no behaviour change. I diffed the regenerated catalog file 
against `main` and confirmed the 15 `javaType` values are the only fields that 
differ, with no header added or removed and no change to the option sections.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to